-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace image caching system with Glide 4 #2871
base: master
Are you sure you want to change the base?
Conversation
This is first published to see what Codacy/Findbugs complain… |
9531702
to
faaa55b
Compare
keep up the good work guys, let me know if I can help test this |
Thanks @nachoparker. This will be soon in dev version, so you can then give us feedback (you can install it in parallel): |
@AndyScherzinger @mario I tried again to get this SVG working in external links, but I do not know why it fails. So I would go on with review & merge it and keep the issue separate. |
fine by me, I'll just run another test and then I think we would be good to go. |
ebad8bf
to
64530cf
Compare
@tobiasKaminsky Just tested, so the thumbnails now seems to be the right ones but scrolling+fetching doesn't seem to work. So if I scroll slowly so that some thumbnails on the shown list are already there, the next ones get fetched, if I scroll faster and stop then the thumbnails aren't fetched anymore :( |
If you leave the folder and navigate back into it the thumbnails previously not shown do show up now but only the ones from the scroll-positions where I have been before. So it seems the fetching gets triggered but they don't get displayed navigating back/forth they are shown (i guess because they are now in the cache). |
@tobiasKaminsky please, let me know when this is out in dev |
@tobiasKaminsky what about the usage comments by @AndyScherzinger ? |
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky not ready? |
No :( Unfortunately I did not had any time to dive into it :/ |
needs a rebase (with lots of conflicts to be solved) |
if this can use for newest server ? |
@codeRemark the branch should work with the latest server while this branch is very outdated (see conflicts) and has quite some bugs to iron out first (see todo list in original description). So the branch is in need of a proper rebase and bugfixing. Other than that given the UI revamp that is happening at the moment there might be even more code conflicts in the near future. |
This replaces our old image caching system with Glide 4.
I first updated Glide 3 to 4 and then replaced our old system step by step.
Unfortunately it was not really possible to have this in smaller steps :-(
Info:
TODO:
After finishing, I will squash and rebase.