Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gallery Search #14532

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improve Gallery Search #14532

wants to merge 8 commits into from
+221 −231

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 10, 2025 •
edited
Loading

  • Tests written, or not not needed

  • Use Coroutines instead of AsyncTask

  • Do not create a new instance of the GallerySearchTask for each search

  • Do not create date instance for each search

Before

before.mp4

After

after.mp4

@alperozturk96
Rename .java to .kt
26d9f2c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
use coroutine
88a770b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
236f53a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
dont create date instance for release mode
298f33e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
update license
66f162c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
no need to override onPause
2578eca 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
99725f0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
5ec1040 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14532.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5756
Dodgy code292289
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total499495

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14532-Screenshot-blue-Light-16-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alperozturk96