Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check API Level for READ_MEDIA_VISUAL_USER_SELECTED Permission #14524

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 10, 2025

  • Tests written, or not not needed

Screenshot 2025-02-10 at 10 55 13

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.31.0 milestone Feb 10, 2025
@alperozturk96 alperozturk96 force-pushed the use-correct-permissions branch 2 times, most recently from 96e65c5 to 706b45a Compare February 10, 2025 10:13
@tobiasKaminsky
Copy link
Member

Detekt fails

@alperozturk96 alperozturk96 force-pushed the use-correct-permissions branch from 706b45a to 1771c92 Compare February 10, 2025 11:25
Signed-off-by: alperozturk <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings5554
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total501501

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14524.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky tobiasKaminsky merged commit eef4356 into master Feb 11, 2025
19 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the use-correct-permissions branch February 11, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants