Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase PIN Enter Delay #14509

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Increase PIN Enter Delay #14509

merged 8 commits into from
Feb 10, 2025

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 6, 2025 •
edited
Loading

  • Tests written, or not not needed
part_test.mp4

@alperozturk96 alperozturk96 force-pushed the increase-pin-enter-delay branch from 1e6a140 to b13e519 Compare February 6, 2025 11:05
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.31.0 milestone Feb 10, 2025
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.31

@tobiasKaminsky
Copy link
Member

delay needs to be persistent:

  • type wrong code
  • see 15s delay
  • close app
  • open app
  • I can directly enter another code

tobiasKaminsky
tobiasKaminsky requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delay needs to be persistent

@alperozturk96 alperozturk96 force-pushed the increase-pin-enter-delay branch from 54cc1a4 to b003524 Compare February 10, 2025 09:56
@alperozturk96
increase delay
4180cd9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
show live delay
19e22e6 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix start value
f359834 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
revert brute_force_delay
2f6c76e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
count minute parts
e8c34f5 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
remove unused resource
b3acccf 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
persist delay
bd78477 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the increase-pin-enter-delay branch from 6d2edb1 to bd78477 Compare February 10, 2025 10:13
@alperozturk96
fix delay
fc2d063 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14509.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total501501

@tobiasKaminsky tobiasKaminsky merged commit 6117fd2 into master Feb 10, 2025
19 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the increase-pin-enter-delay branch February 10, 2025 14:12
@backportbot backportbot bot mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky