Open "on device" correctly when coming from "Uploads" #14493
Closed
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Feb 4, 2025
•
tobiasKaminsky
commented
- Tests written, or not not needed
|
/backport to stable-3.31 |
Signed-off-by: tobiasKaminsky <[email protected]>
alperozturk96
force-pushed
the
uploadNotification
branch
from
7836bdc to
52608bc
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14493.apk |
alperozturk96
requested changes
Feb 11, 2025
| @@ -589,7 +589,18 @@ private void onNavigationItemClicked(final MenuItem menuItem) { | |||
| startPhotoSearch(menuItem.getItemId()); | |||
| } else if (itemId == R.id.nav_on_device) { | |||
| EventBus.getDefault().post(new ChangeMenuEvent()); | |||
| showFiles(true, false); | |||
There was a problem hiding this comment.
showFiles(true, false); is doing exactly the same thing. I think the issue happens sometimes and sometimes not, which might be why you are unable to reproduce it with this PR.
There was a problem hiding this comment.
Indeed. So not a solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.