Remove Login Flow v1 #14461
Remove Login Flow v1 #14461
Conversation
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
remove-login-flow-v1
branch
from
8d1f415 to
30c42fb
Compare
| @@ -253,9 +225,6 @@ public class AuthenticatorActivity extends AccountAuthenticatorActivity | |||
| private String token; | |||
|
|
|||
| private boolean onlyAdd = false; | |||
| @SuppressLint("ResourceAsColor") @ColorInt | |||
| private int primaryColor = R.color.primary; | |||
There was a problem hiding this comment.
Unused variable after removing the login flow v1
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14461.apk |
| @@ -1043,24 +895,6 @@ private void onGetServerInfoFinish(RemoteOperationResult result) { | |||
| webViewPassword != null && !webViewPassword.isEmpty()) { | |||
| checkBasicAuthorization(webViewUser, webViewPassword); | |||
| } else { | |||
| new Thread(() -> { | |||
There was a problem hiding this comment.
This remote operation is only used for the primaryColor. Since primaryColor is not used, no need for this remote operation.
| @@ -421,9 +384,8 @@ public void onNothingSelected(AdapterView<?> parent) { | |||
|
|
|||
| private void deleteCookies() { | |||
| try { | |||
| CookieSyncManager.createInstance(this); | |||
There was a problem hiding this comment.
No need to use CookieSyncManager. Document
| CookieManager.getInstance().removeAllCookies(null); | ||
| } catch (AndroidRuntimeException e) { |
There was a problem hiding this comment.
On Android 8, if the device has WebView Shell as the default web browser.
CookieManager.getInstance().removeAllCookies(null);
This function will throw the IllegalArgumentException.
Android 8
a8.mp4
Android 15
a15.mp4