BugFix - NetworkOnMainThreadException: FileDataStorageManager.saveFileWithParent

[alperozturk96]

• Tests written, or not not needed

[codecov]

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 25.27%. Comparing base (d12464a) to head (0faedb3).

Files with missing lines	Patch %	Lines
...loud/android/datamodel/FileDataStorageManager.java	39.28%	15 Missing and 2 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #14268       +/-   ##
=============================================
+ Coverage          0   25.27%   +25.27%     
- Complexity        0     3429     +3429     
=============================================
  Files             0      689      +689     
  Lines             0    50649    +50649     
  Branches          0     6821     +6821     
=============================================
+ Hits              0    12804    +12804     
- Misses            0    35866    +35866     
- Partials          0     1979     +1979     

Files with missing lines	Coverage Δ
...loud/android/datamodel/FileDataStorageManager.java	56.93% <39.28%> (ø)

... and 688 files with indirect coverage changes

[tobiasKaminsky]

I think FileDataStorageManager shall not handle this.
Instead, as seen in the linked bug, the root cause is that requestUploadOfFilesFromFileSystem() from FileDisplayActivity runs on MainThread.

[tobiasKaminsky]

Please fix in FileDisplayActivity

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	56	56
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	296	296
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	506	506

[alperozturk96]

I think FileDataStorageManager shall not handle this. Instead, as seen in the linked bug, the root cause is that requestUploadOfFilesFromFileSystem() from FileDisplayActivity runs on MainThread.

After your comment, I checked again, and the actual issue is with the method:

void isNetworkAndServerAvailable(@NonNull GenericCallback<Boolean> callback);

This callback runs on the main thread, which is necessary for some cases. However, in other cases, like this one, it must run on a background thread instead of the main thread.

Current Usage of isNetworkAndServerAvailable:

Must run on a background thread:
• fileOperationsHelper?.removeFiles
• fileDataStorageManager.addRemoveFileOfflineOperation
• FileUploadHelper.Companion.instance().uploadNewFiles
• fileDataStorageManager.addCreateFileOfflineOperation

Must run on the main thread:
• DisplayUtils.showSnackMessage
• ocFileListFragment.setEmptyListMessage
• fileDisplayActivity.refreshCurrentDirectory

To address this, it would be better to create a new PR. Before proceeding, I want to inform you because this PR will touch multiple files. While it won’t be a large PR, it will require careful testing.

What do you think? Is it okay for you?

[alperozturk96]

@tobiasKaminsky How are we going to proceed? I explained earlier I have to change multiple files to fix this issue. Shall I create a PR for that?