Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist upload timestamp #13310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

persist upload timestamp #13310

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jul 23, 2024 •
edited
Loading

  • Tests written, or not not needed

@nextcloud nextcloud deleted a comment from github-actions bot Dec 17, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Dec 17, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Dec 17, 2024
alperozturk96
alperozturk96 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It's working without any issue for me.

However, I noticed something, but I think it can't be related with this PR. Image previewing looks different.

shh.mp4

@tobiasKaminsky
Copy link
Member Author

/backport to stable 3.31

@tobiasKaminsky
persist upload timestamp
786bbc2 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13310.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Codacy

Lint

TypemasterPR
Warnings5556
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503503

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasKaminsky @alperozturk96