Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose share by mail #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose share by mail #735

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky [email protected]

AlvaroBrey
AlvaroBrey previously approved these changes Oct 26, 2021
@AlvaroBrey
Copy link
Member

Change looks good, but tests are failing

@tobiasKaminsky tobiasKaminsky force-pushed the sendByMail branch 3 times, most recently from 78f9d87 to 8cda379 Compare October 27, 2021 06:51
@tobiasKaminsky
Copy link
Member Author

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

@AlvaroBrey
Copy link
Member

AlvaroBrey commented Oct 27, 2021

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

It seems that most of the crashes are related to OCCapability. Any recent changes there?

@tobiasKaminsky tobiasKaminsky force-pushed the sendByMail branch 3 times, most recently from 20b435d to 1ebf304 Compare November 3, 2021 07:06
@tobiasKaminsky
Copy link
Member Author

All solved except of lint, which complains as another dependency is outdated.

AlvaroBrey
AlvaroBrey previously approved these changes Nov 3, 2021
@tobiasKaminsky
Copy link
Member Author

/rebase

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 49.08%. Comparing base (856c251) to head (e595288).

Files with missing lines Patch % Lines
...sources/status/GetCapabilitiesRemoteOperation.java 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #735      +/-   ##
============================================
+ Coverage     49.02%   49.08%   +0.05%     
- Complexity     1028     1031       +3     
============================================
  Files           215      215              
  Lines          8087     8101      +14     
  Branches       1038     1040       +2     
============================================
+ Hits           3965     3976      +11     
- Misses         3554     3556       +2     
- Partials        568      569       +1     
Files with missing lines Coverage Δ
...cloud/android/lib/resources/status/OCCapability.kt 94.36% <100.00%> (+0.16%) ⬆️
...sources/status/GetCapabilitiesRemoteOperation.java 51.28% <58.33%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 1, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 3, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants