-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend OCCapability to include notes folder location #1665
Open
ZetaTom
wants to merge
1
commit into
master
Choose a base branch
from
feature/open-in-notes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
============================================
+ Coverage 22.69% 22.72% +0.02%
- Complexity 633 638 +5
============================================
Files 222 222
Lines 8407 8415 +8
Branches 1099 1102 +3
============================================
+ Hits 1908 1912 +4
- Misses 6305 6311 +6
+ Partials 194 192 -2
|
Signed-off-by: ZetaTom <[email protected]>
ad0eb99
to
7db0dad
Compare
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3893-IT-stable-10-57/debug/ |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3893-IT-master-10-57/debug/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the android library will now be able to determine the folder where notes are stored. This will be used to determine when to display a Open in Notes button in the files client according to nextcloud/notes-android#1873.
Requires nextcloud/notes#1468