Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - Sharing #1294

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

wip

fa63146
Select commit
Loading
Failed to load commit list.
Open

Deprecate OwncloudClient - Sharing #1294

wip
fa63146
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 13, 2024 in 0s

48.11% (-1.09%) compared to 0c3c568

View this Pull Request on Codecov

48.11% (-1.09%) compared to 0c3c568

Details

Codecov Report

Attention: Patch coverage is 27.55906% with 184 lines in your changes missing coverage. Please review.

Project coverage is 48.11%. Comparing base (0c3c568) to head (fa63146).
Report is 267 commits behind head on master.

Files with missing lines Patch % Lines
...ib/resources/shares/GetShareesRemoteOperation.java 0.00% 68 Missing ⚠️
...b/resources/shares/UpdateShareRemoteOperation.java 32.14% 32 Missing and 6 partials ⚠️
...ources/shares/GetSharesForFileRemoteOperation.java 0.00% 25 Missing ⚠️
.../lib/resources/shares/GetShareRemoteOperation.java 19.04% 17 Missing ⚠️
...b/resources/shares/RemoveShareRemoteOperation.java 11.11% 16 Missing ⚠️
...om/owncloud/android/lib/common/OwnCloudClient.java 12.50% 7 Missing ⚠️
...b/resources/shares/CreateShareRemoteOperation.java 82.35% 4 Missing and 2 partials ⚠️
...lib/resources/shares/GetSharesRemoteOperation.java 72.72% 4 Missing and 2 partials ⚠️
...droid/lib/common/OwnCloudAnonymousCredentials.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1294      +/-   ##
============================================
- Coverage     49.20%   48.11%   -1.09%     
- Complexity     1001     1004       +3     
============================================
  Files           208      208              
  Lines          7819     8052     +233     
  Branches       1017     1057      +40     
============================================
+ Hits           3847     3874      +27     
- Misses         3419     3613     +194     
- Partials        553      565      +12
Files with missing lines Coverage Δ
...loud/android/lib/common/accounts/AccountUtils.java 5.00% <ø> (ø)
...cloud/android/lib/resources/shares/ShareUtils.java 33.33% <100.00%> (+33.33%) ⬆️
...droid/lib/common/OwnCloudAnonymousCredentials.java 37.50% <0.00%> (ø)
...b/resources/shares/CreateShareRemoteOperation.java 68.53% <82.35%> (-11.47%) ⬇️
...lib/resources/shares/GetSharesRemoteOperation.java 67.39% <72.72%> (-7.61%) ⬇️
...om/owncloud/android/lib/common/OwnCloudClient.java 40.95% <12.50%> (-3.49%) ⬇️
...b/resources/shares/RemoveShareRemoteOperation.java 39.47% <11.11%> (-28.71%) ⬇️
.../lib/resources/shares/GetShareRemoteOperation.java 38.09% <19.04%> (-32.74%) ⬇️
...ources/shares/GetSharesForFileRemoteOperation.java 0.00% <0.00%> (ø)
...b/resources/shares/UpdateShareRemoteOperation.java 33.60% <32.14%> (-26.97%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

View more details on Codecov