Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallelize block splitting #110

Draft
wants to merge 2 commits into
base: rust
Choose a base branch
from
Draft

parallelize block splitting #110

wants to merge 2 commits into from

Conversation

mmolari
Copy link
Collaborator

@mmolari mmolari commented Jan 20, 2025

parallelize block splitting during reweave

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Jan 20, 2025

@mmolari This looks alright technically, but in my measurements has no effect at all on running time of the program, just like the changes in #108.

Unless you insist on this, I propose we convert it to draft PR and wait for better days when we figure out why this happens.

It might be that this place is simply not a bottleneck, and no matter how you speedup a 0.1% portion of total run time, even if we make this code complete in 0 ms, the program still runs in the same time overall. Or it could be that any speedup is erased by the threading overhead (e.g. data sharing between threads). We need some more research and probably a parallel traversal.

I leave the final decision to you.

@mmolari
Copy link
Collaborator Author

mmolari commented Jan 20, 2025

I agree, you're right. Let's leave this open for now and think about this later, it's just a marginal improvement...

@mmolari mmolari marked this pull request as draft January 20, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants