Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Extend tests for BLS12-381 with json tests from EIP-2537 #12929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrLSD
Copy link

@mrLSD mrLSD commented Feb 14, 2025

Description

Extended tests for BLS12-381 with json tests from EIP-2537: https://github.com/ethereum/execution-spec-tests
for NEP-488 implementation

➡️ It's related to bug: #12928
➡️ Successfull tests pass: aurora-is-near/aurora-engine#990

This PR added json cases that were prepared: aurora-is-near/sputnikvm#78

In the tests added special restrictions, to avoid bug from: #12928

@mrLSD mrLSD requested a review from a team as a code owner February 14, 2025 00:13
@mrLSD mrLSD requested a review from Longarithm February 14, 2025 00:13
@olga24912
Copy link
Contributor

Thank you for finding the bug and for the additional tests!

I will add all these tests in another PR, in a slightly different format, along with the bug fix from #12928.

@Longarithm
Copy link
Member

@olga24912 should we close the PR? Or could you assign someone from @near/contract-runtime for review?

@mrLSD
Copy link
Author

mrLSD commented Feb 14, 2025

Hello @olga24912 , @Longarithm
I'm a bit confused about the intention of closing that PR. As it's an opensource contribution, I'm expecting to proposal for changes if in general you're agree about NEP-488 tests changes.
If you just close PR, it will mean declining my contribution to the project.
@olga24912 if you have some related changes, it'll be logically to propose for me changes or operate your own in that PR as co-author.

@olga24912
Copy link
Contributor

@Longarithm, @mrLSD

Alright, let's continue with this PR if you think it's the better approach. I'll make my changes after this PR is merged to avoid conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants