feat: global contract usage #12886
Open
feat: global contract usage #12886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ear/nearcore into stefan/global_contract_account_support
…bal_contract_usage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12886 +/- ##
==========================================
- Coverage 70.53% 70.48% -0.05%
==========================================
Files 851 854 +3
Lines 174921 175594 +673
Branches 174921 175594 +673
==========================================
+ Hits 123374 123765 +391
- Misses 46420 46686 +266
- Partials 5127 5143 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
reviewed
Feb 10, 2025
This reverts commit 067c5bb.
stedfn
force-pushed
the
stefan/global_contract_usage
branch
from
ac40cd9 to
b4c4c2f
Compare
pugachAG
requested changes
Feb 13, 2025
integration-tests/src/test_loop/tests/contract_distribution_cross_shard.rs
Outdated
Show resolved
Hide resolved
pugachAG
requested changes
Feb 14, 2025
pugachAG
requested changes
Feb 14, 2025
runtime/runtime/src/actions.rs
Outdated
| // TODO(#12716): implement global contract usage | ||
| let key = TrieKey::GlobalContractCode { identifier: action.contract_identifier.clone().into() }; | ||
| if !state_update.contains_key(&key)? { | ||
| return Err(RuntimeError::GlobalContractError(GlobalContractError::IdentifierNotFound( |
There was a problem hiding this comment.
almost missed that: returning Err here indicates internal error, so this will fail the whole chunk application. instead you should set error result for this action, like we do that for action_deploy_global_contract:
result.result = Err(ActionErrorKind::GlobalContractIdentifierNotFound {...}).into());
return Ok(());
note that we need to add ActionErrorKind instead of new RuntimeError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds testing and support for the
UseGlobalContractaction. Part of #12716