Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVCPLAN-5555: Add support for SUSE #27

Merged
merged 1 commit into from
Jun 11, 2024
Merged

SVCPLAN-5555: Add support for SUSE #27

merged 1 commit into from
Jun 11, 2024

Conversation

billglick
Copy link
Member

This is being tested on control-test-opensuse155a.

@billglick billglick self-assigned this Jun 5, 2024
@billglick billglick force-pushed the wglick/SVCPLAN-5555/support_suse branch from f520e55 to f3cad72 Compare June 5, 2024 18:57
@billglick billglick marked this pull request as ready for review June 5, 2024 18:59
@billglick billglick requested review from bsper2 and jakerundall June 5, 2024 18:59
jakerundall
jakerundall approved these changes Jun 10, 2024
View reviewed changes
Copy link

@jakerundall jakerundall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I guess that profile_update_os::yum_upgrade::yum_config_file is not actually used for Suse but it seems just as good to leave it defined as-is in Hiera (as opposed to setting it to "" or something like that).

@billglick billglick merged commit d399b09 into main Jun 11, 2024
4 checks passed
@billglick billglick deleted the wglick/SVCPLAN-5555/support_suse branch June 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakerundall jakerundall jakerundall approved these changes

@bsper2 bsper2 Awaiting requested review from bsper2

Assignees

@billglick billglick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billglick @jakerundall