Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Enhance documentation for PullMaxMessagesWithBytesLimit and PullMaxBytes #1796

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[IMPROVED] Enhance documentation for PullMaxMessagesWithBytesLimit and PullMaxBytes #1796

merged 1 commit into from
Feb 4, 2025

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Feb 4, 2025

Signed-off-by: Piotr Piotrowski [email protected]

@piotrpio piotrpio requested a review from wallyqs February 4, 2025 17:08
wallyqs
wallyqs approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 84.82% (+0.01%) from 84.807%
when pulling d5d7e00 on add-note-about-max-bytes-value
into 81d2fae on main.

@piotrpio piotrpio merged commit 5a2c74a into main Feb 4, 2025
6 checks passed
@piotrpio piotrpio deleted the add-note-about-max-bytes-value branch February 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrpio @coveralls @wallyqs