Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby warnings #158

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix ruby warnings #158

merged 1 commit into from
Jan 10, 2025

Conversation

palkan
Copy link
Collaborator

@palkan palkan commented Jan 10, 2025

This is an upgraded version of #150.

The only warnings left are from third-party gems:

$ RUBYOPT="-W" be rspec

/opt/homebrew/lib/ruby/gems/3.3.0/gems/nkeys-0.1.0/lib/nkeys/keypair.rb:56: warning: method redefined; discarding old public_key
/opt/homebrew/lib/ruby/gems/3.3.0/gems/nkeys-0.1.0/lib/nkeys/keypair.rb:78: warning: method redefined; discarding old private_key

/Users/vladimirdementyev/dev/nats-pure.rb/spec/support/dns.rb:28: warning: method redefined; discarding old initialize
/opt/homebrew/lib/ruby/gems/3.3.0/gems/resolv-replace-0.1.1/lib/resolv-replace.rb:23: warning: previous definition of initialize was here

...

Closes #150

@palkan palkan mentioned this pull request Jan 10, 2025
@palkan palkan requested a review from wallyqs January 10, 2025 17:46
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 1ad40f5 into main Jan 10, 2025
14 checks passed
@wallyqs wallyqs deleted the fix/ruby-warnings branch January 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants