Rearchitected the chip folder structure #46
Conversation
| set(SOURCES | ||
| count.cpp | ||
| ) | ||
| set(ENABLED_CHIPS "" CACHE STRING "Enable each listed chip rather than auto-detect") |
There was a problem hiding this comment.
should you only set this ifndef AUTO_ENABLE_CHIPS?
There was a problem hiding this comment.
This is tricky, it would require a FORCE over the user's selection so I'm inclined to think it's better this way.
if (all)
glob cmake files
else if (some)
check some exists
else
none enabled
| count.cpp | ||
| ) | ||
| set(ENABLED_CHIPS "" CACHE STRING "Enable each listed chip rather than auto-detect") | ||
| set(found_chips "") |
There was a problem hiding this comment.
similarly, should you only enable this ifdef AUTO_ENABLE_CHIPS?
| file(GLOB_RECURSE found_chips "*chip.cmake") | ||
| else() | ||
| foreach(_chip ${ENABLED_CHIPS}) | ||
| if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/${_chip}/chip.cmake") |
There was a problem hiding this comment.
Doesn't this fail silently if the chip is in the enable list but not found?
There was a problem hiding this comment.
There's a line about which chips were turned on. I think when someone says -DENABLED_CHIPS="blah blah" and then don't see one of the chips in the output that's a good indicator.
This allows us to select and add new chips at configure time. Paves the way for defining optional modules and chat integrations that are not required.