Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10284: Implement UMM-Vis 1.0.0 in All CMR Environments #2207

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Jan 7, 2025

Overview

What is the feature/fix?

[ECSE-1719] UMM-Vis 1.0.0 changes have been made. We needed to duplicate these changes in CMR.

What is the Solution?

Update visualization schema changes

What areas of the application does this impact?

Visualization in generic apis

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 self-assigned this Jan 7, 2025
@jmaeng72 jmaeng72 requested a review from eereiter January 7, 2025 21:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.26%. Comparing base (8a9eacc) to head (47264bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2207   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files        1056     1056           
  Lines       71082    71082           
  Branches     2032     2031    -1     
=======================================
  Hits        41419    41419           
- Misses      27765    27766    +1     
+ Partials     1898     1897    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants