Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Display schema preview for unexecuted nodes #12901

Merged
merged 13 commits into from
Feb 3, 2025

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 28, 2025

Summary

Display schema preview for unexecuted nodes

  • Schemas will be added in a new PR
  • Will only be enabled on internal for now

Testing

  • Use the Asana > get user operation (only schema present in this PR)
  • Enable the feature flag localStorage.setItem('N8N_EXPERIMENT_OVERRIDES', JSON.stringify({ '028_schema_preview': true }));
  • Node after Asana node should show schema preview
  • Any other node/operation should be unaffected
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2293/display-schema-preview-for-unexecuted-nodes

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Jan 28, 2025
@elsmr elsmr requested a review from dana-gill January 29, 2025 14:13
dana-gill
dana-gill previously approved these changes Jan 29, 2025
Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only works for ActiveCampaign Get :)

Copy link

cypress bot commented Jan 29, 2025

n8n    Run #9064

Run Properties:  status check passed Passed #9064  •  git commit bf35095e8d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-2293-display-schema-preview-for-unexecuted-nodes
Run status status check passed Passed #9064
Run duration 04m 21s
Commit git commit bf35095e8d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 433
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found a bug in the schema preview 🐞

  • Other displayMode selected other than schema (ie: table does not work) --> Shows empty
  • ActiveCampaign get:account => no schema but there should be
  • If nothing is executed => no schema

@elsmr elsmr requested a review from dana-gill January 31, 2025 11:10
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 0063bbb into master Feb 3, 2025
37 checks passed
@elsmr elsmr deleted the node-2293-display-schema-preview-for-unexecuted-nodes branch February 3, 2025 07:50
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants