feat(Discord Node): New sendAndWait operation #12894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…discord-sendandwait-operation
michael-radency
added
node/improvement
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
…discord-sendandwait-operation
…discord-sendandwait-operation
…discord-sendandwait-operation
dana-gill
reviewed
Jan 29, 2025
| @@ -20,6 +20,8 @@ export const description: INodeProperties[] = getSendAndWaitProperties( | |||
| undefined, | |||
| { | |||
| noButtonStyle: true, | |||
| defaultApproveLabel: '✓ Approve', | |||
| defaultDisapproveLabel: '✗ Decline', | |||
There was a problem hiding this comment.
I might be using this wrong -- when I tried to configure this on Discord, I don't get a Decline option
There was a problem hiding this comment.
@dana-gill
by default message send with one button option, you need to chose corresponding Approval option
…discord-sendandwait-operation
…discord-sendandwait-operation
dana-gill
requested changes
Jan 30, 2025
Co-authored-by: Dana <[email protected]>
…discord-sendandwait-operation
…hub.com/n8n-io/n8n into node-2325-discord-sendandwait-operation
dana-gill
approved these changes
Jan 31, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2325-discord-sendandwait-operation
|
| Run status |
|
| Run duration | 04m 29s |
| Commit |
|
| Committer | Michael Kret |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New sendAndWait operation
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2325/discord-sendandwait-operation