fix(core): Fix Sentry error reporting on task runners #12495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
netroy
requested changes
Jan 8, 2025
netroy
requested changes
Jan 8, 2025
netroy
approved these changes
Jan 8, 2025
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 14s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
2
|
Passing
|
379
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
48-subworkflow-inputs.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Sub-workflow creation and typed usage > works with type-checked values |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.
12-canvas-actions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Actions > Node hover actions > should execute node |
Test Replay
Screenshots
Video
|
|
16-webhook-node.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Webhook Trigger node > should listen for a DELETE request |
Test Replay
Screenshots
Video
|
|
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry error reporting for task runners is missing key details like release since #12168. This PR restores them.
Context: https://n8nio.slack.com/archives/C069HS026UF/p1736326002589089
Sample error with 1.73.0 release: https://n8nio.sentry.io/issues/6204460655