Import Transition Network groups #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #389. I would have loved to use our json config-based importer for this, but it doesn’t handle group imports yet, and modifying it to inherit from BaseConstituencyGroupListImportCommand rather than BaseImportFromDataFrameCommand was beyond the scope of this ticket.
struan
force-pushed
the
389-transition-groups
branch
from
b173c20 to
d028ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389.
I would have loved to use our json config-based importer for this, but it doesn’t handle group imports yet, and modifying it to inherit from
BaseConstituencyGroupListImportCommandrather thanBaseImportFromDataFrameCommandwas beyond the scope of this ticket.To import the groups, run:
Or just let both commands be run automatically as part of: