Fix some import bugs #623
Fix some import bugs #623
Conversation
|
This looks good. Guess the best way to test it, is to drop my Docker volumes, and run a |
zarino
force-pushed
the
622-dataframe-truthiness
branch
from
9eacd39 to
4162ec9
Compare
There was a problem hiding this comment.
Tested this out locally (dropping my database, removing the relevant lines from skip_imports, then running script/import-all-data) and all the imports that were previously failing now run fine! 🎉
I’ve amended your commits, @struan, to remove the relevant importers from the skip_imports list as you fix the bug in each commit. And I’ve added a minor improvement to the README, to remind myself—if nobody else—in future that when you run this script from scratch, it doesn’t automatically make all the datasets public, so you need to manually edit the visibility via the Django admin.
use df.empty to check for data but also check for None where appropriate Fixes #622
Rather than sharing this across two file. Also updates it to use people.json as a source rather than the now removed constituencies.json
update the christian aid and onward polling importers to use the constituency name lookup from the base importer Fixes #621
zarino
force-pushed
the
622-dataframe-truthiness
branch
from
4162ec9 to
0de5bf2
Compare
Deal with some bugs in import scripts due to either changes in Pandas or moving of data sources.
Fixes #622 and #621