-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
members only datasets frontend v2 #392
members only datasets frontend v2 #392
Conversation
@struan I’ve pushed a fixup commit that adds a yellow section to the bottom of the area page, advertising the extra data for logged in members: ![]() Migrations hell prevented me actually testing this out, so I did the work in (FYI longer term, I think we’ll split this yellow section into two columns, and use one of the columns to host the email signup form required by #377.) |
ee75189
to
3480d29
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## multiple-geometry-staging #392 +/- ##
=============================================================
+ Coverage 82.80% 83.17% +0.36%
=============================================================
Files 100 100
Lines 3077 3007 -70
Branches 347 315 -32
=============================================================
- Hits 2548 2501 -47
+ Misses 454 430 -24
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. |
If a user is logged in they are a member so can access non public datasets
also update tests for this
e70ede0
to
3c853a9
Compare
3c853a9
to
9cb7bd2
Compare
This does three things:
Fixes #280
This replaces #312 which was too out of sync with the area page updates.