Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATASET: Wildlife Trusts reserves #391

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

alexander-griffen
Copy link
Contributor

@alexander-griffen alexander-griffen commented Jan 16, 2024

Fixes #318

It looks like this in the area page:
image

Note: I have omitted unit_type and unit_distribution from these, because I don't think they're quite accurate

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (baf2431) 84.49% compared to head (bd035cb) 84.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files          88       88           
  Lines        2676     2676           
  Branches      271      271           
=======================================
  Hits         2261     2261           
  Misses        351      351           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-griffen alexander-griffen force-pushed the 317-wildlife-trust-reserves-each-constituency branch from 8af10b3 to 026eb2f Compare January 16, 2024 11:56
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One definite change to make to use the updated area page, and some other small comments.

This commit imports the number of reserves in each
parliamentary constituency, as well as the names of
each of these reserves in JSON format. Additionally,
the place template is updated to display the names
of tyhe reserves as tags (similarly to the WI data).
@alexander-griffen alexander-griffen force-pushed the 317-wildlife-trust-reserves-each-constituency branch from 026eb2f to bd035cb Compare January 17, 2024 15:12
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Not totally sure about having the count and the list of locations in separate categories is the only thing.

@struan struan merged commit bd035cb into main Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import data on the Wildlife Trust Nature Reserves in each constituency
3 participants