-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATASET: Wildlife Trusts reserves #391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 84.49% 84.49%
=======================================
Files 88 88
Lines 2676 2676
Branches 271 271
=======================================
Hits 2261 2261
Misses 351 351
Partials 64 64 ☔ View full report in Codecov by Sentry. |
8af10b3
to
026eb2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One definite change to make to use the updated area page, and some other small comments.
hub/management/commands/generate_wildlife_trust_nature_reserves_csv.py
Outdated
Show resolved
Hide resolved
hub/management/commands/generate_wildlife_trust_nature_reserves_csv.py
Outdated
Show resolved
Hide resolved
This commit imports the number of reserves in each parliamentary constituency, as well as the names of each of these reserves in JSON format. Additionally, the place template is updated to display the names of tyhe reserves as tags (similarly to the WI data).
026eb2f
to
bd035cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Not totally sure about having the count and the list of locations in separate categories is the only thing.
Fixes #318
It looks like this in the area page:
![image](https://private-user-images.githubusercontent.com/65429064/297035860-73a92e7e-b066-4eda-bde8-238600dabe1f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTM4MzUsIm5iZiI6MTczOTYxMzUzNSwicGF0aCI6Ii82NTQyOTA2NC8yOTcwMzU4NjAtNzNhOTJlN2UtYjA2Ni00ZWRhLWJkZTgtMjM4NjAwZGFiZTFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA5NTg1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzMTQ4MzY2YzU1MGJhOTJlNTNjMTA2NzZiZWNmNDBlZTZmNmUxN2U1MGM1MmQ3MzE1ODljZmNlNDdjMTJhOGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._zYbQdm0_by3Czorp6jzJ8CnG43Wqsw8L3kLkvz2mFw)
Note: I have omitted unit_type and unit_distribution from these, because I don't think they're quite accurate