-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friends of the Earth constituency reports #388
Friends of the Earth constituency reports #388
Conversation
edf4f9d
to
b86d4b5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## multiple-geometry-staging #388 +/- ##
=============================================================
+ Coverage 84.23% 84.51% +0.28%
=============================================================
Files 96 97 +1
Lines 2778 2829 +51
Branches 282 285 +3
=============================================================
+ Hits 2340 2391 +51
Misses 369 369
Partials 69 69 ☔ View full report in Codecov by Sentry. |
b86d4b5
to
7aaa0c0
Compare
designed to be stored as json with a url property and a link_text property.
Can't put it in data field as it's probably too long so add it directly to the json field.
7aaa0c0
to
5b22f7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to run the import command, I get an exception:
django.core.exceptions.FieldError: Invalid field name(s) for model DataSet: 'no_comparators'.
(This is after having run the migrations in this PR.)
In the meantime, I’ve amended the dataset metadata, and added some styles and markup that should hopefully result in a display like this:
![Screenshot 2024-01-16 at 08 19 49](https://private-user-images.githubusercontent.com/739624/296978204-9abc71ac-d0ca-4435-99dd-e114dbdf9140.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTI5ODAsIm5iZiI6MTczOTYxMjY4MCwicGF0aCI6Ii83Mzk2MjQvMjk2OTc4MjA0LTlhYmM3MWFjLWQwY2EtNDQzNS05OWRkLWUxMTRkYmRmOTE0MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwOTQ0NDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZTFkN2Y0MzE3Njg5Y2I2ZjRjYWYwNjczMzBhZjI5NTBhMDEyY2UxYjg0ZjkzZjhlNzQ5OWM3YzI0M2IxYmVjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OLvcLntPvI7UFDdGbMDpH0yfU-7FcFQQQG9gwKCKsHM)
@zarino I think you need to commit |
@struan I have? :-) |
oh, I see, the path to it in the template is wrong. |
Not all datasets have comparators so it should be possible to say that to avoid unwanted warnings
7fe2365
to
1030abd
Compare
As well as importing the links, this adds a url data type and updates the place card to display this.
Fixes #362