Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends of the Earth constituency reports #388

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

struan
Copy link
Member

@struan struan commented Jan 15, 2024

As well as importing the links, this adds a url data type and updates the place card to display this.

Fixes #362

@struan struan force-pushed the 362-foe-constituency-reports branch from edf4f9d to b86d4b5 Compare January 15, 2024 17:53
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b542356) 84.23% compared to head (7fe2365) 84.51%.

❗ Current head 7fe2365 differs from pull request most recent head 1030abd. Consider uploading reports for the commit 1030abd to get more accurate results

Files Patch % Lines
hub/management/commands/base_importers.py 25.00% 1 Missing and 2 partials ⚠️
hub/models.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           multiple-geometry-staging     #388      +/-   ##
=============================================================
+ Coverage                      84.23%   84.51%   +0.28%     
=============================================================
  Files                             96       97       +1     
  Lines                           2778     2829      +51     
  Branches                         282      285       +3     
=============================================================
+ Hits                            2340     2391      +51     
  Misses                           369      369              
  Partials                          69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@struan struan force-pushed the 362-foe-constituency-reports branch from b86d4b5 to 7aaa0c0 Compare January 15, 2024 18:01
designed to be stored as json with a url property and a link_text
property.
Can't put it in data field as it's probably too long so add it directly
to the json field.
@struan struan force-pushed the 362-foe-constituency-reports branch from 7aaa0c0 to 5b22f7b Compare January 15, 2024 18:11
@struan struan requested a review from zarino January 15, 2024 18:18
Copy link
Member

@zarino zarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to run the import command, I get an exception:

django.core.exceptions.FieldError: Invalid field name(s) for model DataSet: 'no_comparators'.

(This is after having run the migrations in this PR.)

In the meantime, I’ve amended the dataset metadata, and added some styles and markup that should hopefully result in a display like this:

Screenshot 2024-01-16 at 08 19 49

@struan
Copy link
Member Author

struan commented Jan 16, 2024

@zarino I think you need to commit hub/icons/document.html

@zarino
Copy link
Member

zarino commented Jan 16, 2024

@struan I have? :-)

@struan
Copy link
Member Author

struan commented Jan 16, 2024

oh, I see, the path to it in the template is wrong.

@struan struan force-pushed the 362-foe-constituency-reports branch from 7fe2365 to 1030abd Compare January 16, 2024 10:55
@struan struan merged commit 1030abd into multiple-geometry-staging Jan 16, 2024
5 checks passed
@zarino zarino linked an issue Jan 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display links to FoE constituency narrative PDFs for new constituencies
2 participants