[Surrey] Included email footer #5357
Open
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Footer with a banner to subscribe to Surrey's newsletter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5357 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 416 416
Lines 32925 32925
Branches 5289 5289
==========================================
- Hits 27138 27136 -2
- Misses 4225 4226 +1
- Partials 1562 1563 +1 ☔ View full report in Codecov by Sentry. |
davea
requested changes
Feb 6, 2025
| <tr> | ||
| <th class="spacer-cell"></th> | ||
| <th width="[% wrapper_max_width %]" style="[% td_style %][% hint_style %][% banner_style %]"> | ||
| <img src="/cobrands/surrey/images/email.png" alt="" role="presentation" aria-hidden="true" width="24px" height="24px" style="[% banner_image_style %]"> |
There was a problem hiding this comment.
This needs wrapping in inline_image otherwise it doesn't appear in the email client:
Suggested change
| <img src="/cobrands/surrey/images/email.png" alt="" role="presentation" aria-hidden="true" width="24px" height="24px" style="[% banner_image_style %]"> | |
| <img src="[% inline_image('web/cobrands/surrey/images/email.png') %]" alt="" role="presentation" aria-hidden="true" width="24px" height="24px" style="[% banner_image_style %]"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://docs.google.com/document/d/1aDj4ulmCtbmR4oe8TLhfpg2wbLhIHAc_daiYRp-HZcM/edit?tab=t.0#heading=h.ecre3niclkkv
I added a light border to the banner, so the gray background and the green banner is less jarring.
Preview:
