Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kingston/Sutton Echo changes #5334

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

dracos
Copy link
Member

@dracos dracos commented Jan 20, 2025

For https://github.com/mysociety/societyworks/issues/4725 (core ID changes) [skip changelog]

This PR starts with some core changes - simplifying a bit of code to auto-use it where needed (will be useful in future), finds some more Echo IDs that were previously missed, changing the garden end date format, and making sure shared Kingston/Sutton code uses no fixed IDs at all (as they will change over independently of each other at different times).

It then makes a copy of the SLWP code, removes now-unneeded parts of that, and updates with new Echo IDs and locations for data (but at that point is not used by anything). After that's done, it moves Sutton and then Kingston to the new SLWP copy, also removing unneeded parts of the code and updating for new Echo IDs and locations.

Bulky and Garden tests are marked to be skipped; the coverage stats are poor because at this point we're not dealing correctly with requests, garden, or bulky, and much of the copied code is not yet being tested.

For going live, as Sutton is going live before Kingston, the Sutton commits can be taken out and merged separately without the Kingston ones; both can go on staging at present for testing.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 90.29650% with 36 lines in your changes missing coverage. Please review.

Project coverage is 82.26%. Comparing base (98764b8) to head (36822b4).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Roles/Cobrand/SLWP2.pm 90.75% 12 Missing and 15 partials ⚠️
perllib/FixMyStreet/Cobrand/Sutton.pm 82.05% 6 Missing and 1 partial ⚠️
perllib/FixMyStreet/Cobrand/Kingston.pm 92.85% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5334      +/-   ##
==========================================
- Coverage   82.43%   82.26%   -0.17%     
==========================================
  Files         416      417       +1     
  Lines       32979    33283     +304     
  Branches     5308     5367      +59     
==========================================
+ Hits        27186    27381     +195     
- Misses       4220     4304      +84     
- Partials     1573     1598      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the kingston-sutton-echo-changeover branch 3 times, most recently from 73a2535 to 25b58a0 Compare January 27, 2025 15:10
@dracos dracos marked this pull request as ready for review January 27, 2025 15:15
@dracos dracos force-pushed the kingston-sutton-echo-changeover branch 4 times, most recently from dd3e4c8 to 549aab4 Compare February 4, 2025 16:07
@dracos dracos force-pushed the kingston-sutton-echo-changeover branch from 8a2e2f6 to 1f396d8 Compare February 10, 2025 17:17
So we can change over to new Echo handling, have each request it
directly, so can switch separately.
As it is now in a separate Echo instance,
only relevant results will be returned.
There is one service task per service unit; container information is
now on the service unit, not the task; all the IDs have changed.
@dracos dracos force-pushed the kingston-sutton-echo-changeover branch from 26e69a2 to 6ceaeba Compare February 14, 2025 09:37
@dracos dracos force-pushed the kingston-sutton-echo-changeover branch from 6ceaeba to 67ada65 Compare February 14, 2025 10:33
@dracos dracos force-pushed the kingston-sutton-echo-changeover branch from 67ada65 to 5886136 Compare February 14, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant