Skip to content

Commit

Permalink
Reinstate missing margin before reporting form email input
Browse files Browse the repository at this point in the history
`.form-box--logged-in-name` has no preceding heading, which meant the
grey box background was colliding with whatever content happened to go
before it.

We add some margin, and while we’re at it, remove the extra margin-top
on first-child labels (unnecessary, since .form-boxes have their own
padding) and tidy up the syntax of the .form-box rule set.

Fixes #1418.
  • Loading branch information
zarino authored and dracos committed Jul 6, 2016
1 parent f4dad7e commit cb6e735
Showing 1 changed file with 25 additions and 10 deletions.
35 changes: 25 additions & 10 deletions web/cobrands/sass/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -313,24 +313,32 @@ label{
margin: 0 -1em 0.25em;
background: #eee;
padding: 1em;
> input[type=text], input[type=email] {
margin-bottom:1em;

& > input[type=text],
& > input[type=email] {
margin-bottom: 1em;
}

& > label:first-child {
margin-top: 0;
}

.title {
font-size:1.25em;
margin:0.5em 0;
font-size: 1.25em;
margin: 0.5em 0;
}

h2 {
margin: 0 0 0.5em;
}

h5 {
margin:0 0 1em;
font: {
size:1.125em;
weight:normal;
}
margin: 0 0 1em;
font-size: 1.125em;
font-weight: normal;

strong {
font-size:2em;
font-size: 2em;
margin-#{$right}: 0.25em;
}
}
Expand All @@ -342,6 +350,13 @@ label{
margin: 0 0 0.25em;
padding: 1em;
}

// When the user is logged in, we show a shorter form-box,
// without a heading before it. So add some space before.
#form-box--logged-in-name {
margin-top: 1.25em;
}

// Prevent grey displaying oddly by giving it a width, and stop odd left margin issue
.ie7 .form-box {
width: 100%;
Expand Down

0 comments on commit cb6e735

Please sign in to comment.