-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one build
npm script. Add github actions CI
#122
base: master
Are you sure you want to change the base?
Conversation
Thanks for the submission @romang-at-guarda-co Ill have a look at it properly tomorrow. If you are interested in taking it further. Ive made a number of changes to our newer library that can be found here. https://github.com/mymonero/mymonero-utils/tree/master/packages/mymonero-monero-client and here: https://github.com/mymonero/mymonero-utils/tree/master/packages/mymonero-wallet-manager The newer code is using boost headers and the latest emscripten docker image to do the builds. these would fit well with the changes you have made. |
Sorry, I think I'm interested in this repo specifically (I have legacy code that depends on it). |
no problem. just suggesting that you can drop the downloading of boost and the need for a custom emscripten docker container. the code in this repo does work with the latest emscripten and boost headers. |
I think I got it. |
b34f7e7
to
5a17182
Compare
This allows users to build everything like this:
And also adds a github workflow which runs these commands and
npm run test
afterwards to make sure this build works.