Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][MobileStepper] deprecate LinearProgressProps and complete slots, slotProps #45033

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

siriwatknp
Copy link
Member

Part of #41281

  • Deprecate LinearProgressProps in favor of slotProps.progress
  • Added slots, slotProps for root, progress, dots, and dot
  • Updated migration doc with a codemod

@siriwatknp siriwatknp added component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 16, 2025
@mui-bot
Copy link

mui-bot commented Jan 16, 2025

Netlify deploy preview

MobileStepper: parsed: +2.80% , gzip: +2.60%
@material-ui/core: parsed: +0.08% , gzip: +0.05%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 185a5c3

@@ -0,0 +1,15 @@
import MobileStepper from '@mui/material/MobileStepper';
Copy link
Contributor

@sai6855 sai6855 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme.actual.js and theme.expected.js files are missing

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 6, 2025
@siriwatknp siriwatknp requested a review from sai6855 February 6, 2025 10:55
Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left 1 comment

@sai6855
Copy link
Contributor

sai6855 commented Feb 6, 2025

https://github.com/mui/material-ui/blob/master/packages/mui-codemod/README.md i think adding deprecations in this file got missed

@DiegoAndai DiegoAndai added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Feb 7, 2025
@siriwatknp siriwatknp merged commit 5db08b2 into mui:master Feb 7, 2025
24 checks passed
Copy link

github-actions bot commented Feb 7, 2025

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants