Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Support docs images in regression tests #43746

Closed
wants to merge 12 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 13, 2024

Enable images in the regression tests

images seem to be deliberately blocked out of performance considerations. But I'm not seeing a measurable difference in runtime of the regressions test job.

@Janpot Janpot added the test label Sep 13, 2024
@mui-bot
Copy link

mui-bot commented Sep 13, 2024

Netlify deploy preview

https://deploy-preview-43746--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a721541

@Janpot Janpot changed the title Support docs public images in regression tests Support docs images in regression tests Sep 13, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 30, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2024
@Janpot Janpot changed the title Support docs images in regression tests [test] Support docs images in regression tests Oct 1, 2024
@Janpot
Copy link
Member Author

Janpot commented Feb 10, 2025

Works, but benefits not 100% clear.

@Janpot Janpot closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants