Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pulumi-terraform-bridge #473

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

muhlba91
Copy link
Owner

@muhlba91 muhlba91 commented Nov 25, 2024

closes #468 and migrates fully to pulumi-terraform-bridge

Copy link

coderabbitai bot commented Nov 25, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve updating import paths and comments across various files in the Pulumi Proxmox VE SDK. The import paths for the tfbridge and tfgen packages have been modified to reflect a version upgrade to v3. Additionally, numerous comments in the example usage sections have been altered from "Managed by Terraform" to "Managed by Pulumi," ensuring that documentation aligns with the current branding. The overall functionality and structure of the code remain unchanged.

Changes

File Path Change Summary
provider/cmd/pulumi-resource-proxmoxve/main.go Import path updated from github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge to github.com/pulumi/pulumi-terraform-bridge/v3/pkg/pf/tfbridge.
provider/cmd/pulumi-tfgen-proxmoxve/main.go Import path updated from github.com/pulumi/pulumi-terraform-bridge/pf/tfgen to github.com/pulumi/pulumi-terraform-bridge/v3/pkg/pf/tfgen.
provider/resources.go Import path updated from github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge to github.com/pulumi/pulumi-terraform-bridge/v3/pkg/pf/tfbridge.
sdk/dotnet/Acl.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/HA/Haresource.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Network/FirewallAlias.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Network/FirewallIPSet.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Network/FirewallSecurityGroup.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Permission/Group.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Permission/Pool.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/Permission/User.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/dotnet/User/Token.cs Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/acl.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/ha/haresource.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/network/firewallAlias.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/network/firewallIPSet.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/network/firewallSecurityGroup.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/permission/group.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/permission/pool.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/permission/user.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/go/proxmoxve/user/token.go Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/Acl.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/HA/Haresource.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/User/Token.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/network/FirewallAlias.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/network/FirewallIPSet.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/network/FirewallSecurityGroup.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/permission/Group.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/permission/Pool.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/java/src/main/java/io/muehlbachler/pulumi/proxmoxve/permission/User.java Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/acl.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/ha/haresource.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/network/firewallAlias.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/network/firewallIPSet.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/network/firewallSecurityGroup.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/permission/group.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/permission/pool.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/permission/user.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/nodejs/user/token.ts Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/acl.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/ha/ha_resource.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/network/firewall_alias.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/network/firewall_ip_set.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/network/firewall_security_group.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/permission/group.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/permission/pool.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/permission/user.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.
sdk/python/pulumi_proxmoxve/user/token.py Comment updated from "Managed by Terraform" to "Managed by Pulumi" in example usage.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SDK
    participant Provider

    User->>SDK: Create Resource
    SDK->>Provider: Send Create Request
    Provider-->>SDK: Acknowledge Creation
    SDK-->>User: Resource Created
Loading

Assessment against linked issues

Objective Addressed Explanation
Update module github.com/pulumi/pulumi-terraform-bridge/pf to v0.49.0 (#468)

Possibly related PRs

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 Biome (1.9.4)
sdk/nodejs/.pnp.cjs

The --json option is unstable/experimental and its output might change between patches/minor releases.
Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: crates/biome_console/src/lib.rs:149:14
Thread Name: main
Message: called Result::unwrap() on an Err value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gitstream-cm bot commented Nov 25, 2024

Pull requests from the repository owner are approved automatically.

@muhlba91 muhlba91 merged commit 8ce3feb into main Nov 25, 2024
14 of 15 checks passed
@muhlba91 muhlba91 deleted the feat/pulumi-terraform-bridge branch November 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant