Automatic updates to allowlist - 2024-06-24T15:25:42 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
It's an edge case, but if our sitemap contains links that then 30x to another site, we'll still scan the HTML of those pages (but we don't spider any deeper than that). We don't want to follow redirects from pages in our sitemap, as we end up with unexpected results, and could end up adding URLs to the allowlist that we don't need. This change stops the following of redirects, and the response.text involved with 30x responses is an empty string, which is fine for all the processing which is attempted on responses, so we don't need to add complexity of status-code checking right now.
|
Closing this as was made by a branch not |
stevejalim
deleted the
update-data-allowlist-mozorg.yaml--2024-06-24T15-25-42
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While scanning the site, the following outbound URLs were detected in the site:
Found in:
Found in:
Found in:
Found in:
Found in:
They have been automatically added to the allowlist, as featured in this pull request.
Please do not just approve and merge without checking
For each URL mentioned above:
Hopefully this PR saves you time and effort.
CheckerBot
--
Fingerprint: 3bd0a802d3812e99a3c167ab3a13d321