New widget #150
Merged
New widget #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull readme changes
New widget with different display options (see docs/widger.js) and demos (in public/widgets/demos). Also provides solutions for mozillascience#142 (loading spinner) and mozillascience#135 (DOIs with extra slashes)
Closed
|
Thanks for the new PR! I'll take a closer look this afternoon :) |
| </body> | ||
| </html> | ||
| ``` | ||
| You can either use paper-badger-widget.js ([documentation](docs/paper-badger-widget.md)), which supports old browsers or widget.js ([documentation](docs/widget.md)), which is in development and currently only supports evergreen browsers and IE9+. |
There was a problem hiding this comment.
I like how you handled this! Thanks.
We may want to start a wiki and move those docs there, but in the meantime this is great.
|
Looks great -- there's a couple comments I left in |
|
Thanks for the review! I changed the docs in the necessary places. |
|
Looks good to me! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #148 and Gitter I moved the code for the new widget to a seperate file. This provides solutions to #135 and #142 (I don't know if I should mark them as solved because these issues still exist in the original widget implementation).
This version of the widget currently only supports evergreen browsers and IE9+.