Fixes #740: Expand patterns in settings #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
740-expand-patterns-config
branch
from
778cd01 to
4bc9bff
Compare
leplatrem
force-pushed
the
740-expand-patterns-config
branch
2 times, most recently
from
c67bc52 to
704fd19
Compare
leplatrem
force-pushed
the
740-expand-patterns-config
branch
from
49ea66f to
8901f50
Compare
alexcottner
reviewed
Jan 30, 2025
config/local.ini
Outdated
| @@ -114,6 +114,9 @@ kinto.signer.autograph.server_url = http://autograph:8000 | |||
| kinto.signer.autograph.hawk_id = kintodev | |||
| kinto.signer.autograph.hawk_secret = 3isey64n25fim18chqgewirm6z2gwva1mas0eu71e9jtisdwv6bd | |||
|
|
|||
| # quicksuggest collections don't new review | |||
| kinto.signer.staging.quicksuggest-(\w+)-(desktop|mobile).to_review_enabled = false | |||
There was a problem hiding this comment.
I had the bucket wrong :) it's main-workspace
alexcottner
reviewed
Jan 30, 2025
| @@ -154,9 +155,11 @@ def includeme(config): | |||
| r, ["source", "destination", "preview", "to_review_enabled"] | |||
| ) | |||
| for r in resources.values() | |||
| if "(" not in str(r["source"]) # do not show patterns | |||
There was a problem hiding this comment.
Removing this line does not affect the unit tests.
There was a problem hiding this comment.
Hmm, I don't agree:
FAILED kinto-remote-settings/tests/signer/test_plugin_setup.py::ExpandedSettingsTest::test_expanded_settings_are_updated_on_collection_creation - AssertionError: assert 'magic-(\\w+)' not in {None, 'source', 'magic-(\\w+)', 'from', 'onecrl'}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #740
With this approach, we turn glob settings into real settings:
Current limitations:
.in regexps to match collections names (eg([a-zA-Z0-9_-]*)instead of(.*))()to enable expansionsI believe it is good enough to get started with our use case (see issue description)