Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention server error responses in clients specifications #734

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

leplatrem
Copy link
Contributor

No description provided.

@leplatrem leplatrem requested a review from a team as a code owner January 14, 2025 13:46

Every response is JSON.

If the HTTP status is not OK (<200 or >=400), the response contains a JSON mapping, with the following attributes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we return any response codes < 200? I don't think pyramid supports them.

Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nit comment.

@leplatrem leplatrem merged commit 70d39c6 into main Jan 16, 2025
5 checks passed
@leplatrem leplatrem deleted the clients-specs-errors branch January 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants