Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Kinto Admin from sources #525

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Pull Kinto Admin from sources #525

merged 4 commits into from
Jan 16, 2024

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jan 15, 2024 •
edited
Loading

  • verify default behaviour
  • check that admin runs at specified version (by downgrading it for example)
  • verify behaviour of env var vs. ini setting: .ini setting has no effect if the env var is not empty

@leplatrem leplatrem requested a review from a team as a code owner January 15, 2024 19:06
@leplatrem leplatrem added the dependencies Pull requests that update a dependency file label Jan 16, 2024
grahamalama
grahamalama reviewed Jan 16, 2024
View reviewed changes
RemoteSettings.Dockerfile Outdated Show resolved Hide resolved
bin/build-kinto-admin.sh Outdated Show resolved Hide resolved
@leplatrem leplatrem enabled auto-merge (squash) January 16, 2024 17:53
@leplatrem leplatrem merged commit 15776ce into main Jan 16, 2024
5 checks passed
@leplatrem leplatrem deleted the pull-admin-from-sources branch January 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @grahamalama