Skip to content

Commit

Permalink
Bug 1766069 [wpt PR 33762] - Avoid adding nested pseudo elements twic…
Browse files Browse the repository at this point in the history
…e in a11y tree, a=testonly

Automatic update from web-platform-tests
Avoid adding nested pseudo elements twice in a11y tree

Some nested pseudo elements can get added twice in the tree,
when their layout parent and DOM parent lead to different AXObjects
that can both add them.

A good solution will pass both of these tests:
All/DumpAccessibilityTreeTest.AccessibilityCSSFirstLetter/blink
external/wpt/accessibility/crashtests/bdo-table-cell.html

This code will go away once legacy layout is completely removed.
See discussion in CL.

Bug: 1314808
Change-Id: I6a993cd3981719240737a79be79afd3b65ca42b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591572
Reviewed-by: Rune Lillesveen <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Reviewed-by: Daniel Libby <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#996484}

--

wpt-commits: fbee830531f584487c0633d6b8a90a8e81958a84
wpt-pr: 33762
  • Loading branch information
aleventhal authored and moz-wptsync-bot committed May 15, 2022
1 parent 34b679e commit e7c6d3e
Showing 1 changed file with 21 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!doctype html>
<link rel="help" href="https://crbug.com/1314808">
<style>
item:after { display: block; content: open-quote; }
item { display: list-item; }
</style>
<bdo style="direction:rtl">
x<mark></mark>
</bdo>
<span style="display: table-cell; column-width: 0px;"></span>
<script>
const new_listitem_child = document.createElement('item');
document.querySelector('mark').appendChild(new_listitem_child);
</script>


<!--
ax_object.cc(739)] Check failed: child != this. Previous parent still has |this| child:\n
ERR: "\\"ListMarker\\" axid#14 <::marker> needsToUpdateChildren" should be a child of "\\"ListItem\\" axid#12 <item> needsToUpdateChildren" not of "\\"GenericContainer\\" axid#13 <::after> #children=2"\n
-->

0 comments on commit e7c6d3e

Please sign in to comment.