-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linux autofill CI failures #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-c-at-moz
changed the title
[IGNORE] lengthen timeouts for xfail tests in autofill
Fix linux autofill CI failures
Jan 18, 2025
whlpatricia
previously approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds crazy!
whlpatricia
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
philimon-reset
pushed a commit
that referenced
this pull request
Jan 23, 2025
* lengthen timeouts for xfail tests in autofill * restrict tc runs * find error details * fill with different function * try screenshots * moar screenshots * moar screenshots * add one sleep * wait for confirmation on cc save * wait for popup to go away * try a hard wait when filling out autofill forms * detach from autofill class methods * skip unnecessary screenshots * more screenshots mid flight * defactor some more * get the source * wait for chrome? * write chrome to artifacts * wait for chrome context, then log * hide autofill menu? * try a new tab? * try headed * try with wayland mode disabled * try with wayland mode disabled * try with wayland mode disabled * try with wayland mode explicitly enabled * try wayland-specific stuff * lint * wayland enable + headed * get documentURI * try 2404 wayland the bad way * try 2404 wayland the bad way * try 2404 wayland the hard way * don't default to pynput import * don't default to pynput import * try headless * try a different way of clicking save * revert everything but the selector * try to fix fullscreen shot on linux * try to fix fullscreen shot on linux 2 * fix linux screenshot * fix with no-save pref * fix with CI setup * try new unlock logic * try bypassing keyring with env vars * try on relsre image * try on relsre image * merge main and rerun on relsre image * force autofill rerun * prove that keyring is still the problem * get pids * write pids to file * try to actually set a password * try to actually set a password * kill keyring daemon and restart with silly password * new meaningless change * what is in the CI list? * fix choose script again * remove xfails * doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix autofill with
timeoutsCI setup shenanigans!Huge breakthrough due to Alexandre L. figuring out how to log into keyring without requiring it to be disabled. This apparently fixes all of our autofill issues in Linux CI.