Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cirrus): Update user id to nimbus user id #12017

Merged
merged 6 commits into from
Jan 17, 2025
Merged

feat(cirrus): Update user id to nimbus user id #12017

merged 6 commits into from
Jan 17, 2025

Conversation

yashikakhurana
Copy link
Contributor

Because

  • To avoid naming confusion for the integrating web application, we are changing the name of field user_id to nimbus_user_id

This commit

  • Rename the field and update the test case

Fixes #12002
Note: Will also update this in the enrollment query- mozilla/bigquery-etl#6595

@yashikakhurana
Copy link
Contributor Author

Blocked on #12008

@yashikakhurana yashikakhurana mentioned this pull request Jan 16, 2025
Open
jaredlockhart
jaredlockhart approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashikakhurana

@jaredlockhart jaredlockhart added this pull request to the merge queue Jan 17, 2025
Merged via the queue into mozilla:main with commit c330a4a Jan 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 api- Modify enrollment events telemetry from user_id to nimbus_user_id
2 participants
@yashikakhurana @jaredlockhart