Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20.18 #5527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.9.x'
node-version: '20.18.x'
- run: npm ci
- run: npm run build-glean
# Verify that the build (incl. type-checking) succeeds
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20.9.x
node-version: 20.18.x

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_pr_full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20.9.x
node-version: 20.18.x

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e_pr_smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20.9.x
node-version: 20.18.x

- name: Install dependencies
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lighthouse_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
id-token: write
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.9.x
- name: Use Node.js 20.18.x
uses: actions/setup-node@v4
with:
node-version: 20.9.x
node-version: 20.18.x
- name: Run Lighthouse CI
run: |
npm install -g @lhci/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.9.x'
node-version: '20.18.x'
- run: npm ci
- run: npm run build-glean
- run: npm run build-nimbus
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unittests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.9.x'
node-version: '20.18.x'
- run: npm ci
- run: npm run build-glean
# Run the regular tests on push
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20.9-alpine
FROM node:20.18-alpine

RUN addgroup -g 10001 app && \
adduser -D -G app -h /app -u 10001 app
Expand Down Expand Up @@ -41,4 +41,4 @@ RUN --mount=type=secret,id=SENTRY_AUTH_TOKEN,env=SENTRY_AUTH_TOKEN \
GLEAN_PIP=pip \
npm run build

CMD ["npm", "start"]
CMD ["npm", "start"]
2 changes: 1 addition & 1 deletion esbuild.cronjobs.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ build({
format: "esm",
outdir: "dist/scripts/cronjobs/",
sourcemap: true,
target: "node20.9",
target: "node20.18",
packages: "external",
});
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
# Default build command.
command = "npm ci; npm run build-storybook"

environment = { NODE_VERSION = "20.9.0", NPM_VERSION = "10.1.0" }
environment = { NODE_VERSION = "20.18.2", NPM_VERSION = "10.1.0" }
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"description": "Firefox Monitor",
"engines": {
"node": "20.9.x",
"node": "20.18.x",
"npm": "10.1.x"
},
"type": "module",
Expand Down Expand Up @@ -66,7 +66,7 @@
"homepage": "https://github.com/mozilla/blurts-server",
"license": "MPL-2.0",
"volta": {
"node": "20.9.0",
"node": "20.18.2",
"npm": "10.1.0"
},
"dependencies": {
Expand Down
Loading