Cirrus has enrolments as an array #5509
Conversation
|
Preview URL 🚀 : https://blurts-server-pr-5509-mgjlpikfea-uk.a.run.app |
|
Hm I think you're right, here's the sample that the Nimbus team gave us https://gist.github.com/yashikakhurana/f2fec74b0b6182d03adf957ceedd41b3 |
|
I'd like to land the other PRs first and see what's going on with stage, this was definitely working (with the So I'd like to understand the current state after things are rolled back before we land, I don't doubt that this is a problem though I just want to understand the sequence of what happened. |
|
Hm maybe there is a problem with the documentation... I did test this and it worked as expected (with V2), I'll re-test before we land this. It might be a bug in Cirrus (or its docs). |
|
Stage is working now with everything else landed, I flipped the So I think it's OK to land this one, I think we might need to dig into this one some more though. |
|
@rhelmer That does indicate that we need to fix this, but I'm still not sure that this PR is the right fix. (Or actually, I'm fairly sure it's not.) I still have this open question for Yashika about how to pass the enrollments to Glean, given that Glean only accepts single enrollments. |
|
Waiting for an update to Glean.js to support arrays in |
|
@rhelmer Alright, updated this PR to no longer send the enrollment data to Glean, as discussed (since Glean.js probably won't be updated to support receiving the full enrollment data in the near future). |
i.e. make their names plural where they accept arrays.
Glean.js doesn't support sending complex objects in extra_keys, so we can't send the enrollment data there yet. We will look into doing that when Glean.js is updated.
Vinnl
force-pushed
the
multiple-enrollments
branch
from
7d5da75 to
d19ee5d
Compare
|
Cleanup completed - database 'blurts-server-pr-5509' destroyed, cloud run service 'blurts-server-pr-5509' destroyed |
This PR I'm not sure about, and it's probably wrong, but: in MNTOR-3812, @rhelmer showed an example with
Enrollmentsbeing an array, whereas our code says that it's a single object.I'm not sure if it actually is, and if it is, I'm not sure why and how we're supposed to handle it - in this PR, I'm just always getting the first element, but that's probably not correct. However, I figured I'd submit this PR to at least have this observation in play somewhere.