Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fxci): Normalize 'resource.name' in fxci_derived.worker_costs_v1 #5809

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

ahal
Copy link
Member

@ahal ahal commented Jun 19, 2024

It seems that the resource.name field from the billing export can sometimes take the form:

projects/<id>/instances/<name>

And other times it's simply:

<name>

Update the worker costs query to account for this.

Issue: #5759

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
  • If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
    in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
  • If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
  • When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

It seems that the `resource.name` field from the billing export can
sometimes take the form:

    projects/<id>/instances/<name>

And other times it's simply:

    <name>

Update the worker costs query to account for this.

Issue: mozilla#5759
@ahal ahal force-pushed the fxci_fix_worker_cost branch from ab42212 to 13a3d58 Compare June 19, 2024 18:58
@akkomar akkomar enabled auto-merge (squash) June 21, 2024 13:39
@akkomar akkomar merged commit 624d8b4 into mozilla:main Jun 21, 2024
21 checks passed
@ahal ahal deleted the fxci_fix_worker_cost branch June 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants