-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate L10n extraction locally and in CI #12800
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12800 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 267 267
Lines 10600 10600
Branches 3221 3221
=======================================
Hits 10419 10419
Misses 168 168
Partials 13 13 ☔ View full report in Codecov by Sentry. |
f3a1b22
to
294556f
Compare
Generated this PR: #12801 |
7644112
to
92daf39
Compare
I've merged all of the scripts into a single zx executable. It extracts and merges locales for the current code base. It is pretty fast 2x the previous set of scripts (<15seconds locally and in CI) Local Options
CI options
All options would work, it's more about the kind of experience we want to have. |
9df4428
to
4b047e0
Compare
e891702
to
74b3ca9
Compare
82204e9
to
64f0481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
'Project-Id-Version': 'amo', | ||
'Report-Msgid-Bugs-To': 'EMAIL@ADDRESS', | ||
'POT-Creation-Date': potCreationDate, | ||
'PO-Revision-Date': 'YEAR-MO-DA HO:MI+ZONE', | ||
'Last-Translator': 'FULL NAME <EMAIL@ADDRESS>', | ||
'Language-Team': 'LANGUAGE <[email protected]>', | ||
'MIME-Version': '1.0', | ||
'Content-Type': 'text/plain; charset=utf-8', | ||
'Content-Transfer-Encoding': '8bit', | ||
'plural-forms': 'nplurals=2; plural=(n!=1);', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of this looks a bit boilerplate-y (e.g. EMAIL@ADDRESS
) - does it need updating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied verbatim from here. I could actually remove the webpack config file while we are here as that is no longer referenced or needed.
Fixes: mozilla/addons#14848
Testing
PR on origin: Link
PR on fork: TBD