This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
Bookmark panel refactor #5203
Open
Bookmark panel refactor #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piatra
force-pushed
the
bookmark-panel-refactor
branch
from
c171c4b to
15fe30a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR to adjust the panel height #5172 I realized there are some things that can be improved for the BookmarkPanelHub.
Specifically we were keeping around a reference to the
windowanddocumentwhere the bookmark action happened and we were using this in most of the code. It made it very difficult to test and to mock for ASRAdmin. I find it clearer to pass thewindowobject as argument to the function.I combined this with another asrouter admin request: open the bookmark panel when previewing the message.
And this works with preview endpoints without any code change (and it opens the panel automatically when you navigate to the url)
To test:
Test url
about:newtab?endpoint=https://gist.githubusercontent.com/piatra/d193ca7e0f513cc19fc6a1d396c214f7/raw/a9d815080912078008613cc476a197034c998013/bookmark_endpoint.jsonPreview
