[MC-1608] Allow engagement to have a corpus_item_id #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmiermans
commented
Jan 6, 2025
| "region": "US", | ||
| "click_count": 1, | ||
| "impression_count": 5, | ||
| }, |
There was a problem hiding this comment.
The scope of this PR is limited to allowing the GCS file to have a corpus_item_id attribute. It's not actually used in Merino yet, so simply adding this data to the test fixture is sufficient to cover the existing functionality.
jpetto
approved these changes
Jan 6, 2025
mmiermans
force-pushed
the
mc-1608-corpus-item-engagement
branch
from
1715288 to
314b62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: MC-1608
Description
Allow the GCS engagement file to have a
corpus_item_idattribute. This attribute will be present once mozilla/bigquery-etl#6743 is merged.PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)