Skip to content

Commit

Permalink
default
Browse files Browse the repository at this point in the history
  • Loading branch information
lukaszkolodziejczyk committed Jan 20, 2025
1 parent 8afce33 commit 3adc0ff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
6 changes: 1 addition & 5 deletions mostlyai/qa/reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def report(
max_sample_size_accuracy: int | None = None,
max_sample_size_embeddings: int | None = None,
statistics_path: str | Path | None = None,
update_progress: ProgressCallback | None = None,
update_progress: ProgressCallback = lambda *args, **kwargs: None,
) -> tuple[Path, ModelMetrics | None]:
"""
Generate an HTML report and metrics for assessing synthetic data quality.
Expand Down Expand Up @@ -120,10 +120,6 @@ def report(
if hol_tgt_data is not None and hol_ctx_data is None:
raise ValueError("If syn_ctx_data is provided, then hol_ctx_data must also be provided.")

if update_progress is None:

def update_progress(*args, **kwargs): ...

with TemporaryWorkspace() as workspace:
# ensure all columns are present and in the same order as training data
syn_tgt_data = syn_tgt_data[trn_tgt_data.columns]
Expand Down
6 changes: 1 addition & 5 deletions mostlyai/qa/reporting_from_statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def report_from_statistics(
report_extra_info: str = "",
max_sample_size_accuracy: int | None = None,
max_sample_size_embeddings: int | None = None,
update_progress: ProgressCallback | None = None,
update_progress: ProgressCallback = lambda *args, **kwargs: None,
) -> Path:
"""
Generate an HTML report based on previously generated statistics and newly provided synthetic data samples.
Expand All @@ -71,10 +71,6 @@ def report_from_statistics(
The path to the generated HTML report.
"""

if update_progress is None:

def update_progress(*args, **kwargs): ...

with TemporaryWorkspace() as workspace:
# prepare report_path
if report_path is None:
Expand Down

0 comments on commit 3adc0ff

Please sign in to comment.