-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug crash #1894
Fix debug crash #1894
Conversation
Implementation is based on mono#1819.
Seems like its failing due to: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Mind updating the version of the action too? Probably enough to just switch to v4. Not having much luck lately with CI deprecations 🫤 |
Ah yeah, I did update it in #1893. I could port that over to this commit if you'd like to test this PR? |
I thought we need to get this merged first, right? Because you said this fixes the CI for the other PR. In that case then yes. |
Sure thing, let me get that done in a bit. It's not really 'needed', but then we can merge these both with green checks. |
That should do it I think |
a7c2402
to
7e4c1b4
Compare
Ah I missed one line when I ported this over. Fixed that now ( |
Looks pretty good, nice work :) |
This fixes crashes when running the parser in the debug builds, due to the assert getting triggered. This will also fix CI for #1893.
Implementation is based on #1819.
Additionally I've added a commit that updates the assert to trigger a debug break, to automatically get notified of any errors. It will now also trigger in DebugOpt builds